Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - spacetime upgrade takes --yes instead of deprecated --force #1805

Merged
merged 1 commit into from
Oct 5, 2024
Merged

CLI - spacetime upgrade takes --yes instead of deprecated --force #1805

merged 1 commit into from
Oct 5, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Oct 5, 2024

Description of Changes

I missed making this change in #1752. This PR migrates spacetime upgrade to --yes as well.

API and ABI breaking changes

Yes, this breaks spacetime upgrade --force.

Expected complexity level and risk

1

Testing

$ cargo run -- upgrade 0.12.0 --yes
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s
     Running `target/debug/spacetime upgrade 0.12.0 --yes`
Finding version...done.
You're already running the latest version: 0.12.0
Skipping confirmation due to --yes
You are currently running version 0.12.0 of spacetime. The version you're upgrading to is 0.12.0.
This will replace the current executable at /mnt/nutera/work/localhd-symlinks/SpacetimeDBPrivate/public/target/debug/spacetime.
Skipping confirmation due to --yes
  Downloading update... 18.64MiB/18.64MiB (0s)

@bfops bfops added CLI only This change only affects the CLI behavior api-break labels Oct 5, 2024
@bfops bfops requested a review from jdetter October 5, 2024 00:03
@bfops bfops added release-any To be landed in any release window release-1.0 labels Oct 5, 2024
@bfops bfops enabled auto-merge October 5, 2024 00:06
@bfops bfops added this pull request to the merge queue Oct 5, 2024
Merged via the queue into master with commit 126dcae Oct 5, 2024
13 checks passed
@bfops bfops deleted the bfops/upgrade-force branch October 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutiertyler cloutiertyler cloutiertyler approved these changes

@jdetter jdetter Awaiting requested review from jdetter

Assignees
No one assigned
Labels
CLI only This change only affects the CLI behavior release-1.0 release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfops @cloutiertyler